Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18130#discussion_r118824449
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -202,12 +202,13 @@ class JobProgressListener(conf: SparkConf) extends
SparkListener with Logging {
}
jobIdToData(jobStart.jobId) = jobData
activeJobs(jobStart.jobId) = jobData
- for (stageId <- jobStart.stageIds) {
- stageIdToActiveJobIds.getOrElseUpdate(stageId, new
HashSet[StageId]).add(jobStart.jobId)
- }
+
// If there's no information for a stage, store the StageInfo received
from the scheduler
// so that we can display stage descriptions for pending stages:
for (stageInfo <- jobStart.stageInfos) {
+ stageIdToActiveJobIds.getOrElseUpdate(stageInfo.stageId,
--- End diff --
It's not immediately clear to me they're equivalent. They'd have to contain
the same set of stage IDs. Is it worth it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
