Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18086#discussion_r118832466
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
 ---
    @@ -91,7 +92,12 @@ object ResolveHints {
               ResolvedHint(h.child, HintInfo(isBroadcastable = Option(true)))
             } else {
               // Otherwise, find within the subtree query plans that should be 
broadcasted.
    -          applyBroadcastHint(h.child, h.parameters.toSet)
    +          applyBroadcastHint(h.child, h.parameters.map {
    +            case tableName: String => tableName
    +            case tableId: UnresolvedAttribute => tableId.name
    +            case unsupported => throw new AnalysisException("Broadcast 
hint parameter should be " +
    +              s" identifier or string but was $unsupported 
(${unsupported.getClass}")
    --- End diff --
    
    Nit: `s" identifier or string` -> `s"an identifier or string `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to