Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118844675
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -107,6 +110,14 @@ class SimpleFunctionRegistry extends FunctionRegistry {
functionBuilders.remove(name).isDefined
}
+ override def dropMacro(name: String): Boolean = synchronized {
--- End diff --
A drop function can currently also drop a macro. Can you make sure that
this cannot happen?
Maybe we should consolidate this into a single drop function with a `macro`
flag. cc @gatorsmile WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
