Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2516#discussion_r18060382
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -188,18 +188,18 @@ class SparkConf(loadDefaults: Boolean) extends 
Cloneable with Logging {
       def getExecutorEnv: Seq[(String, String)] = {
         val prefix = "spark.executorEnv."
         getAll.filter{case (k, v) => k.startsWith(prefix)}
    -          .map{case (k, v) => (k.substring(prefix.length), v)}
    +      .map{case (k, v) => (k.substring(prefix.length), v)}
       }
     
       /** Get all akka conf variables set on this SparkConf */
       def getAkkaConf: Seq[(String, String)] =
    -    /* This is currently undocumented. If we want to make this public we 
should consider
    -     * nesting options under the spark namespace to avoid conflicts with 
user akka options.
    -     * Otherwise users configuring their own akka code via system 
properties could mess up
    -     * spark's akka options.
    -     *
    -     *   E.g. spark.akka.option.x.y.x = "value"
    -     */
    +  /* This is currently undocumented. If we want to make this public we 
should consider
    --- End diff --
    
    The previous indentation was actually correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to