Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18074#discussion_r119072616
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala
---
@@ -153,12 +153,13 @@ case class WindowExec(
}
/**
- * Collection containing an entry for each window frame to process. Each
entry contains a frames'
- * WindowExpressions and factory function for the WindowFrameFunction.
+ * Collection containing an entry for each window frame to process. Each
entry contains a frame's
+ * [[WindowExpression]]s and factory function for the
WindowFrameFunction.
*/
private[this] lazy val windowFrameExpressionFactoryPairs = {
type FrameKey = (String, FrameType, Option[Int], Option[Int])
type ExpressionBuffer = mutable.Buffer[Expression]
+ type WindowExpressionBuffer = mutable.Buffer[WindowExpression]
--- End diff --
@jaceklaskowski this is still not reverted. Please, back out any non-doc
changes. I can't spend 4 rounds of review on things like this, it's not fair to
anyone else waiting
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
