Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18144#discussion_r119124578
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -1007,6 +1007,17 @@ object functions {
       def map(cols: Column*): Column = withExpr { CreateMap(cols.map(_.expr)) }
     
       /**
    +   * Creates a new map column. The input columns must be grouped as 
key-value pairs, e.g.
    +   * (key1, value1, key2, value2, ...). The key columns must all have the 
same data type, and can't
    +   * be null. The value columns must all have the same data type.
    +   *
    +   * @group normal_funcs
    +   * @since 2.3
    +   */
    +  @scala.annotation.varargs
    +  def map(colName: String, colNames: String*): Column = map((colName +: 
colNames).map(col) : _*)
    --- End diff --
    
    nit: need bracket:
    ```
    def map(colName: String, colNames: String*): Column = {
      map((colName +: colNames).map(col) : _*)
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to