Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/17094
Overall looks good to me. I think it's a good step to clean up the codebase
and reduce the duplicated code.
I think the impl is pretty well thought through. A few comments (that
probably should be part of follow up):
1. I'd like to think about ways the regularizer(s) could be made more like
"function composition" since the loss and reg are both just `DiffFunctions`
2. I think there should be scope for factoring out the loss functions into
some sort of traits to make things cleaner
The one thing that doesn't feel quite right is the fact that the std
scaling finds its way into `L2Regularization` - it sort of feels like the
abstraction is leaking there. Not quite sure how to address it (perhaps we
could look at something in line with the way OWLQN does it's L1 reg?).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
