Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17723#discussion_r119244128
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HiveCredentialProvider.scala
---
@@ -29,11 +29,10 @@ import org.apache.hadoop.io.Text
import org.apache.hadoop.security.{Credentials, UserGroupInformation}
import org.apache.hadoop.security.token.Token
-import org.apache.spark.SparkConf
import org.apache.spark.internal.Logging
import org.apache.spark.util.Utils
-private[security] class HiveCredentialProvider extends
ServiceCredentialProvider with Logging {
+private[security] class HiveCredentialProvider extends
HadoopDelegationTokenProvider with Logging {
--- End diff --
Is this the only reason we need to make spark core depend on hive? My
concern is that, previously it's possible for users to build spark without
hive, but now it's impossible.
Can we move this file to hive module and use reflection in
`ConfigurableCredentialManager`? so that if users build spark without hive and
wanna use `HiveCredentialProvider`, we throw an exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
