Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r119275552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1077,7 +1080,8 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
case expressions =>
expressions
}
- val function =
UnresolvedFunction(visitFunctionName(ctx.qualifiedName), arguments, isDistinct)
+ val function = UnresolvedFunction(visitFunctionName(ctx.qualifiedName,
trimFuncName),
--- End diff --
This way we have repeated code for different `visitXXFunctionName` methods.
If the handling logic is changed in the future, we need to change in many
methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
