GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/18161
[MINOR][PYTHON] Ignore pep8 on test scripts in work directory generated in
tests
## What changes were proposed in this pull request?
Currently, if we run `./python/run-tests.py` and they are aborted without
cleaning up this directory, it fails pep8 check due to some Python scripts
generated. For example,
https://github.com/apache/spark/blob/7387126f83dc0489eb1df734bfeba705709b7861/python/pyspark/tests.py#L1955-L1968
```
PEP8 checks failed.
./work/app-20170531190857-0000/0/test.py:5:55: W292 no newline at end of
file
./work/app-20170531190909-0000/0/test.py:5:55: W292 no newline at end of
file
./work/app-20170531190924-0000/0/test.py:3:1: E302 expected 2 blank lines,
found 1
./work/app-20170531190924-0000/0/test.py:7:52: W292 no newline at end of
file
./work/app-20170531191016-0000/0/test.py:5:55: W292 no newline at end of
file
./work/app-20170531191030-0000/0/test.py:5:55: W292 no newline at end of
file
./work/app-20170531191045-0000/0/test.py:3:1: E302 expected 2 blank lines,
found 1
./work/app-20170531191045-0000/0/test.py:7:52: W292 no newline at end of
file
```
This is a bit annoying to check pep8 sometimes.
This PR proposes to exclude these (assuming we want to skip per
https://github.com/apache/spark/blob/master/.gitignore#L73).
Also, it moves other pep8 configurations in the script into ini
configuration file in pep8.
## How was this patch tested?
Manually tested via `./dev/lint-python`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark work-exclude-pep8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18161.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18161
----
commit 968d9e7e08d730863427cfc48c49ebee82724919
Author: hyukjinkwon <[email protected]>
Date: 2017-05-31T10:38:58Z
Ignore pep8 on work directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
