GitHub user zsxwing opened a pull request:

    https://github.com/apache/spark/pull/18168

    [SPARK-20940][Core]Replace IllegalAccessError with IllegalStateException

    ## What changes were proposed in this pull request?
    
    `IllegalAccessError` is a fatal error (a subclass of LinkageError) and its 
meaning is `Thrown if an application attempts to access or modify a field, or 
to call a method that it does not have access to`. Throwing a fatal error for 
AccumulatorV2 is not necessary and is pretty bad because it usually will just 
kill executors or SparkContext 
([SPARK-20666](https://issues.apache.org/jira/browse/SPARK-20666) is an example 
of killing SparkContext due to `IllegalAccessError`). I think the correct type 
of exception in AccumulatorV2 should be `IllegalStateException`.
    
    ## How was this patch tested?
    
    Jenkins

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zsxwing/spark SPARK-20940

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18168
    
----
commit 76601a7860413174c0e5eb97d7b0402d34013fc3
Author: Shixiong Zhu <[email protected]>
Date:   2017-05-31T21:14:09Z

    Replace IllegalAccessError with IllegalStateException

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to