Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17947#discussion_r119504377
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -833,6 +833,14 @@ private[spark] object SparkSubmitUtils {
       // Exposed for testing
       var printStream = SparkSubmit.printStream
     
    +  // Exposed for testing.
    +  // We need to specify each component explicitly, otherwise we miss 
spark-streaming-kafka-0-8 and
    +  // other spark-streaming utility components. Underscore is there to 
differentiate between
    +  // spark-streaming_2.1x and spark-streaming-kafka-0-8-assembly_2.1x
    +  val components = Seq("catalyst_", "core_", "graphx_", "launcher_", 
"mllib_", "mllib-local_",
    --- End diff --
    
    since it's in global scope now can we rename it to something more 
meaningful?
    `IVY_DEFAULT_EXCLUDES`
    
    Also add to the docs, since it has lost its context from the method and the 
docs now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to