Github user bogdanrdc commented on a diff in the pull request:
https://github.com/apache/spark/pull/18086#discussion_r119561805
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -407,7 +407,7 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
val withWindow = withDistinct.optionalMap(windows)(withWindows)
// Hint
- withWindow.optionalMap(hint)(withHints)
+ hints.asScala.foldRight(withWindow)(withHints)
--- End diff --
so that `select /*+ hint1() /* /*+ hint2() */`produces `Hint1(Hint2(plan))`
and not `Hint2(Hint1(plan))`. `withHints` adds a Hint on top so the last one
folded is the top most.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
