Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17723#discussion_r119778509
--- Diff: core/pom.xml ---
@@ -357,6 +357,34 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-crypto</artifactId>
</dependency>
+
+ <!--
+ Testing Hive reflection needs hive on the test classpath only.
+ It doesn't need the spark hive modules, so the -Phive flag is not
checked.
+ -->
+ <dependency>
+ <groupId>${hive.group}</groupId>
+ <artifactId>hive-exec</artifactId>
--- End diff --
> Why not just add the Hive dependencies to compile scope?
Because technically Hive is an optional dependency for Spark, and moving it
to compile scope would break that.
(Whether that should change or not is a separate discussion, but probably
better not to have it as part of this change.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]