Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18158#discussion_r119859774
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -461,19 +461,17 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProperties with Logging {
def assertResolves(before: String, after: String): Unit = {
// This should test only single paths
assume(before.split(",").length === 1)
- // Repeated invocations of resolveURI should yield the same result
def resolve(uri: String): String = Utils.resolveURI(uri).toString
+ assert(resolve(before) === after)
--- End diff --
Thanks for asking me. The initial change proposed looked testing several
duplicated test cases and also changing existing tests to me. I am fine with
the current status.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
