Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18189#discussion_r119979389
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala
---
@@ -51,19 +51,16 @@ case class ResolvedHint(child: LogicalPlan, hints:
HintInfo = HintInfo())
}
-case class HintInfo(
- isBroadcastable: Option[Boolean] = None) {
+case class HintInfo(forceBroadcast: Boolean = false) {
/** Must be called when computing stats for a join operator to reset
hints. */
- def resetForJoin(): HintInfo = copy(
- isBroadcastable = None
- )
+ def resetForJoin(): HintInfo = copy(forceBroadcast = false)
override def toString: String = {
- if (productIterator.forall(_.asInstanceOf[Option[_]].isEmpty)) {
- "none"
+ if (forceBroadcast) {
+ "forceBroadcast=true"
} else {
- isBroadcastable.map(x => s"isBroadcastable=$x").getOrElse("")
+ "none"
--- End diff --
Instead `none`, we can just show `forceBroadcast=true` or
`forceBroadcast=false`, since it's not an `Option` now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
