Github user zhengcanbin commented on the issue:
https://github.com/apache/spark/pull/18192
@jerryshao It's a tiny change for more reasonable code structure. There
exists three `ShuffleWriter ` implementations, we first use the helper method
`SortShuffleWriter#shouldBypassMergeSort` to determine whether a shuffle should
use `BypassMergeSort` pathï¼and then use another helper method
`SortShuffleManager#canUseSerializedShuffle` for deciding `UnsafeShuffleWriter`
path. From view of code structure consistencyï¼method `shouldBypassMergeSort`
should not belong to `SortShuffleWriter`ï¼it should be included in
`BypassMergeSortShuffleWriter` or `SortShuffleManager`, and better for the
later one to put the two helper methods together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
