Github user adrian-ionescu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18159#discussion_r120339182
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -446,7 +451,12 @@ case class DataSource(
dataSource.createRelation(
sparkSession.sqlContext, mode, caseInsensitiveOptions,
Dataset.ofRows(sparkSession, data))
case format: FileFormat =>
-
sparkSession.sessionState.executePlan(planForWritingFileFormat(format, mode,
data)).toRdd
+ val qe =
sparkSession.sessionState.executePlan(planForWritingFileFormat(format, mode,
data))
+ qe.executedPlan.transform {
+ case f: FileWritingCommandExec =>
+ val newCmd =
f.cmd.withExternalMetrics(externalMetrics.getOrElse(null))
+ FileWritingCommandExec(newCmd, f.children)
+ }.execute()
--- End diff --
I don't think this is much of an improvement over the previous hack.. See
above comments, try to avoid changing this code at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
