Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18221#discussion_r120677922
  
    --- Diff: project/SparkBuild.scala ---
    @@ -240,7 +240,8 @@ object SparkBuild extends PomBuild {
     
         javacOptions in Compile ++= Seq(
           "-encoding", "UTF-8",
    -      "-source", javacJVMVersion.value
    +      "-source", javacJVMVersion.value,
    +      "-Xlint:unchecked"
    --- End diff --
    
    This is enabling the unchecked checks, not suppressing them. I don't think 
you can enable the checks in source code.  And if I read things correctly, it's 
enabled in the maven build (`-Xlint:all,-serial,-path`).
    
    I can remove the flag if it really bothers people, though (I didn't notice 
much extra noise from enabling it, and it helped me spot these occurrences in 
the code I'm adding.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to