Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18231#discussion_r120768040
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -209,4 +190,47 @@ private ShuffleMetrics() {
}
}
+ private class ManagedBufferIterator implements Iterator<ManagedBuffer> {
+
+ private int index = 0;
+ private String appId;
+ private String execId;
+ private String shuffleId;
+ // mapId and reduceId are stored as bytes to save memory.
+ private byte[][] mapIdAndReduceIds;
+
+ ManagedBufferIterator(String appId, String execId, String[] blockIds) {
+ this.appId = appId;
--- End diff --
Wonder if you see a lot of these in your heap dump too? You could
potentially intern `appId` and `execId` for some extra memory savings, if you
see a lot of those.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
