Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18210#discussion_r120844928
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -336,9 +336,9 @@ private[scheduler] object BlacklistTracker extends
Logging {
*/
def isBlacklistEnabled(conf: SparkConf): Boolean = {
conf.get(config.BLACKLIST_ENABLED) match {
- case Some(enabled) =>
+ case enabled =>
enabled
- case None =>
+ case _ =>
--- End diff --
This needs to be `getBoolean`. All of the other boolean properties have a
default. It doesn't make sense here to have a third branch that deal with "not
set" because a blacklist must either be enabled or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
