Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18083#discussion_r120972760
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -23,29 +23,41 @@ import scala.collection.JavaConverters._
import scala.reflect.ClassTag
import scala.util.control.NonFatal
+import com.codahale.metrics.Timer
+
import org.apache.spark.internal.Logging
/**
* An event bus which posts events to its listeners.
*/
private[spark] trait ListenerBus[L <: AnyRef, E] extends Logging {
+ private[this] val listenersPlusTimers = new CopyOnWriteArrayList[(L,
Timer)]
--- End diff --
shall we use `Option[Timmer]` as value type?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
