Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17747#discussion_r120971242
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -110,6 +117,14 @@ class HistoryServer(
appCache.getSparkUI(appKey)
}
+ val historyMetrics = new HistoryMetrics(this, "history.server")
+
+ /**
+ * Provider metrics are None until the provider is started, and only
after that
+ * point if the provider returns any.
+ */
+ var providerMetrics: Option[Source] = None
--- End diff --
You only need this as a field because you're using it in tests, otherwise
it can just be a parameter to `startMetrics`. Is there a way you can check the
provider metrics in tests without this reference, e.g. by just looking at the
`metricsSystem`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
