Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2546#discussion_r18089631
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -153,13 +153,18 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
// later than the last known log directory will be loaded.
var newLastModifiedTime = lastModifiedTime
val logInfos = logDirs
- .filter { dir =>
- if (fs.isFile(new Path(dir.getPath(),
EventLoggingListener.APPLICATION_COMPLETE))) {
- val modTime = getModificationTime(dir)
- newLastModifiedTime = math.max(newLastModifiedTime, modTime)
- modTime > lastModifiedTime
- } else {
- false
+ .filter { dir =>
+ try {
--- End diff --
Can you explain why you want to make this change? you didn't include any
info in the title or description, nor was there a linked JIRA. The indentation
is wrong, and you're catching `Exception`, which is likely too broad.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
