Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18150#discussion_r121209859
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/ShuffleMapStage.scala ---
    @@ -160,19 +150,28 @@ private[spark] class ShuffleMapStage(
        * registered with this execId.
        */
       def removeOutputsOnExecutor(execId: String): Unit = {
    +    if (removeOutputsByFilter(x => x.executorId == execId)) {
    +      logInfo("%s is now unavailable on executor %s (%d/%d, %s)".format(
    +        this, execId, _numAvailableOutputs, numPartitions, isAvailable))
    +    }
    +  }
    +
    +  /**
    +   * Removes all shuffle outputs which satisfies the filter. Note that 
this will also
    +   * remove outputs which are served by an external shuffle server (if one 
exists),
    +   * as they are still registered with this execId.
    --- End diff --
    
    We don't mention execId here, so we should update the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to