Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18231#discussion_r121237684
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -209,4 +190,52 @@ private ShuffleMetrics() {
}
}
+ private class ManagedBufferIterator implements Iterator<ManagedBuffer> {
+
+ private int index = 0;
+ private String appId;
+ private String execId;
+ private String shuffleId;
+ // An array containing mapId and reduceId pairs.
+ private int[][] mapIdAndReduceIds;
+
+ ManagedBufferIterator(String appId, String execId, String[] blockIds) {
+ this.appId = appId;
+ this.execId = execId;
+ String[] blockId0Parts = blockIds[0].split("_");
+ if (blockId0Parts.length < 4) {
+ throw new IllegalArgumentException("Unexpected block id format: "
+ blockIds[0]);
+ } else if (!blockId0Parts[0].equals("shuffle")) {
--- End diff --
I think Sean means that since you're throwing in the previous block, `else`
is redundant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
