Github user jimjh commented on the pull request:
https://github.com/apache/spark/pull/2416#issuecomment-56991616
@andrewor14 I made most of the changes you recommended, and simplified the
signature for Spillable.
However, I am not sure how to remove `Spillable`'s type parameter entirely,
because I think child classes should be able to specialize `#spill`. For
example, `ExternalSorter` should provide `spill(collection:
SizeTrackingPairCollection[(Int, K), C])`, but not `spill[C](collection: C)`.
This allows it to pass `collection` along to customized spilling code (such as
`spillToPartitionFiles` and `spillToMergeableFiles`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
