Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18082#discussion_r121268638
--- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql ---
@@ -54,19 +54,4 @@ explain select 3 + 1 || 'a' || 4 / 2;
explain select 1 == 1 OR 'a' || 'b' == 'ab';
explain select 'a' || 'c' == 'ac' AND 2 == 3;
--- math functions
-select cot(1);
-select cot(null);
-select cot(0);
-select cot(-1);
--- ceil and ceiling
-select ceiling(0);
-select ceiling(1);
-select ceil(1234567890123456);
-select ceiling(1234567890123456);
-
--- floor
-select floor(0);
-select floor(1);
-select floor(1234567890123456);
--- End diff --
After rethinking it, maybe we should keep this file untouched in this PR.
The reason is we still can check the type promotion logics here.
Yeah, we still should add the test cases in `MathExpressionsSuite.scala`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
