Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r121269084
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1281,6 +1285,57 @@ class BlockManagerSuite extends SparkFunSuite with
Matchers with BeforeAndAfterE
assert(master.getLocations("item").isEmpty)
}
+ test("SPARK-20640: Shuffle registration timeout and maxAttempts conf are
working") {
+ val shufflePort = 10000
--- End diff --
I'm afraid that this may lead to flakiness in Jenkins: we run multiple
concurrent builds on the machine and they aren't containerized, so hardcoding
ports in unit tests risks port conflicts (especially when several jobs kick off
at about the same time; this actually _is_ an issue in practice).
If you need to know the port that it binds to then I would recommend using
`Utils.startServiceOnPort` (see examples of this in existing tests elsewhere in
the codebase, such as in the Kafka module).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
