Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18259#discussion_r121345316
--- Diff:
core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala ---
@@ -34,6 +34,23 @@ class WorkerSuite extends SparkFunSuite with Matchers {
}
def conf(opts: (String, String)*): SparkConf = new
SparkConf(loadDefaults = false).setAll(opts)
+ private var _worker: Worker = _
+ private def makeWorker(conf: SparkConf): Worker = {
+ assert(_worker === null, "Some Worker's RpcEnv is leaked in tests")
+ val securityMgr = new SecurityManager(conf)
+ val rpcEnv = RpcEnv.create("test", "localhost", 12345, conf,
securityMgr)
+ _worker = new Worker(rpcEnv, 50000, 20, 1234 * 5,
Array.fill(1)(RpcAddress("1.2.3.4", 1234)),
+ "Worker", "/tmp", conf, securityMgr)
+ _worker
+ }
+ after {
--- End diff --
@srowen I agree with you, i will change this one,thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
