Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/2548#discussion_r18115444
--- Diff: python/pyspark/mllib/linalg.py ---
@@ -414,23 +417,32 @@ def stringify(vector):
class Matrix(object):
- """ the Matrix """
- def __init__(self, nRow, nCol):
- self.nRow = nRow
- self.nCol = nCol
+ """
+ Represents a local matrix.
+ """
+
+ def __init__(self, numRows, numCols):
+ self.numRows = numRows
+ self.numCols = numCols
def toArray(self):
+ """
+ Returns its elements in a NumPy ndarray.
+ """
raise NotImplementedError
class DenseMatrix(Matrix):
- def __init__(self, nRow, nCol, values):
- Matrix.__init__(self, nRow, nCol)
- assert len(values) == nRow * nCol
+ """
+ Column-majored dense matrix.
--- End diff --
I'm pretty sure "major" is more common than "majored" (I think this typo
exists elsewhere in MLlib too.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
