Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18301#discussion_r122116294
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -573,8 +586,11 @@ private[execution] final class LongToUnsafeRowMap(val
mm: TaskMemoryManager, cap
private def updateIndex(key: Long, address: Long): Unit = {
var pos = firstSlot(key)
assert(numKeys < array.length / 2)
+ numKeyLookups += 1
--- End diff --
IMO we should. The number of required probes is the different per key, and
is also dependent on the order in which the map was constructed. If you combine
this with some skew and missing keys, the number of probes can be much higher
than expected.
You could even argue that we do not really care about the number of probes
when building the map.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
