Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18025#discussion_r122133379
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -2254,18 +2198,12 @@ setMethod("approxCountDistinct",
                 column(jc)
               })
     
    -#' Count Distinct Values
    +#' @section Details:
    +#' \code{countDistinct}: Returns the number of distinct items in a group.
     #'
    -#' @param x Column to compute on
    -#' @param ... other columns
    --- End diff --
    
    this is the example perhaps we are losing some details by grouping these 
functions - instead of having a line that says "other columns" now we have 
"other arguments" which is perhaps less clear?
    
    thought?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to