Github user danielvdende commented on a diff in the pull request: https://github.com/apache/spark/pull/18304#discussion_r122144727 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -90,6 +90,7 @@ class CSVOptions( val quote = getChar("quote", '\"') val escape = getChar("escape", '\\') val comment = getChar("comment", '\u0000') + val lineSeparator = parameters.getOrElse("lineSeparator", "\n") --- End diff -- Ah, I think I understand now, thanks. Maybe I'm overlooking it, but I don't see the `wholeFile` option being used in `CsvOptions` at all at the moment (nor `multiline`) ? I'll take a further look at fixing this up considering the dependency on `LineRecordReader` (which only supports the two line separators you mentioned)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org