Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16801#discussion_r122326702
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
    @@ -234,7 +234,6 @@ class JobProgressListener(conf: SparkConf) extends 
SparkListener with Logging {
         }
         for (stageId <- jobData.stageIds) {
           stageIdToActiveJobIds.get(stageId).foreach { jobsUsingStage =>
    -        jobsUsingStage.remove(jobEnd.jobId)
    --- End diff --
    
    I understand the issue, but now you're creating a memory leak, since these 
mappings will never be removed, right? Which will also cause the condition in 
the next line to never trigger, causing a memory leak in a different map too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to