Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18308#discussion_r122496127
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -432,8 +432,10 @@ private[spark] class ExecutorAllocationManager(
if (testing || executorsRemoved.nonEmpty) {
executorsRemoved.foreach { removedExecutorId =>
newExecutorTotal -= 1
+ val hasCachedBlocks =
SparkEnv.get.blockManager.master.hasCachedBlocks(removedExecutorId)
--- End diff --
This is a pretty expensive call just so you can print a more accurate log
message... at the very least it should be inside the `logInfo` call:
```
logInfo {
expensiveStuff()
"This is the log message referencing the expensive stuff."
}
```
But I'd prefer a solution that doesn't make this call at all, since INFO is
more often than not enabled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
