Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18235#discussion_r122502830
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -858,19 +844,33 @@ object SparkSubmit extends CommandLineUtils {
require(path != null, "path cannot be null.")
val uri = Utils.resolveURI(path)
uri.getScheme match {
- case "file" | "local" =>
- path
-
+ case "file" | "local" => path
+ case "https" | "http" | "ftp" => path
--- End diff --
This is wrong, right? These need to be downloaded, and now they won't be.
(Whether the `FileSystem` API can download those is a separate question...
if it doesn't, you'll end up with another implementation of
`Utils.doFetchFile`.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
