GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/18336
[MINOR][R] Add knitr and rmarkdown packages/improve output for version info
in AppVeyor tests
## What changes were proposed in this pull request?
This PR proposes two things as below:
**Install packages per documentation** - this does not affect the tests
itself (but CRAN which we are not doing via AppVeyor) up to my knowledge.
This adds `knitr` and `rmarkdown` per
https://github.com/apache/spark/blob/45824fb608930eb461e7df53bb678c9534c183a9/R/WINDOWS.md#unit-tests
**Improve logs/shorten logs** - actually, long logs can be a problem on
AppVeyor (e.g., see https://github.com/apache/spark/pull/17873)
`R -e ...` repeats printing R information for each invocation as below:
```
R version 3.3.1 (2016-06-21) -- "Bug in Your Hair"
Copyright (C) 2016 The R Foundation for Statistical Computing
Platform: i386-w64-mingw32/i386 (32-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
Natural language support but running in an English locale
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
```
It looks reducing the call might be slightly better and print out the
versions together looks more readable.
Before:
```
# R information ...
> packageVersion('testthat')
[1] '1.0.2'
>
>
# R information ...
> packageVersion('e1071')
[1] '1.6.8'
>
>
... 4 more times
```
After:
```
# R information ...
> packageVersion('knitr'); packageVersion('rmarkdown');
packageVersion('testthat'); packageVersion('e1071'); packageVersion('survival')
[1] â1.16â
[1] â1.6â
[1] â1.0.2â
[1] â1.6.8â
[1] â2.41.3â
```
## How was this patch tested?
Before (please see
https://ci.appveyor.com/project/HyukjinKwon/spark/build/169-master)
After (please see the AppVeyor build in this PR):
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark
minor-add-knitr-and-rmarkdown
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18336
----
commit 1bb671796e43f6f73afaae715f44614e17d36f64
Author: hyukjinkwon <[email protected]>
Date: 2017-06-14T08:38:14Z
Add knitr and rmarkdown packages in AppVeyor tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
