GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/18340

    [SPARK-21132] [SQL] DISTINCT modifier of function arguments should not be 
silently ignored

    ### What changes were proposed in this pull request?
    We should not silently ignore `DISTINCT` when they are not supported in the 
function arguments. This PR is to block these cases and issue the error 
messages.
    
    ### How was this patch tested?
    Added test cases for both regular functions and window functions

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark firstCount

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18340
    
----
commit 350852ded1038ea80ed505d29d1ce238c4864778
Author: Xiao Li <gatorsm...@gmail.com>
Date:   2017-06-18T02:29:28Z

    fix.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to