Github user lins05 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18098#discussion_r122612344
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -502,6 +526,23 @@ private[spark] class
MesosCoarseGrainedSchedulerBackend(
)
}
+ private def satisfiesLocality(offerHostname: String): Boolean = {
+ if (!Utils.isDynamicAllocationEnabled(conf) ||
hostToLocalTaskCount.isEmpty) {
+ return true
+ }
+
+ // Check the locality information
+ val currentHosts =
slaves.values.filter(_.taskIDs.nonEmpty).map(_.hostname).toSet
+ val allDesiredHosts = hostToLocalTaskCount.keys.toSet
+ val remainingHosts = allDesiredHosts -- currentHosts
--- End diff --
So we exclude slaves which already have executors launched on them, even if
they match the locality. I guess it's worth adding a comment here explaining
the motivation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
