Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2475#discussion_r18122136
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/avro.scala ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.sql
+
+import org.apache.avro.Schema
+import org.apache.avro.file.DataFileReader
+import org.apache.avro.generic.{GenericRecord, GenericDatumReader}
+import org.apache.avro.mapred.FsInput
+
+import org.apache.hadoop.fs.Path
+
+import org.apache.spark.sql.foreign._
+import org.apache.spark.sql.test.TestSQLContext
+
+import scala.collection.JavaConversions._
+
+/**
+ * An example of a Spark SQL foreign data source for reading data stored
in Avro. Currently this
+ * is only for illustrative purposes and much of the data type conversion
logic still needs to be
+ * written.
+ */
+package object avro extends DataSource {
+
+ /**
+ * Creates a new relation for data store in avro given a `path` as a
parameter.
+ */
+ def createRelation(sqlContext: SQLContext, parameters: Map[String,
String]) = {
+ AvroRelation(parameters("path"))(sqlContext)
+ }
+
+ /**
+ * Adds a method, `avroFile`, to SQLContext that allows reading data
stored in Avro.
+ */
+ implicit class AvroContext(sqlContext: SQLContext) {
+ def avroFile(filePath: String) = AvroRelation(filePath)(sqlContext)
+ }
+
+ case class AvroRelation(location: String)(val sqlContext: SQLContext)
+ extends BaseRelation with TableScan {
+
+ val schema = {
--- End diff --
declare the type explicitly for schema and buildScan. I think that's much
more important here because this is going to be an example where people learn
to use this ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
