Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17758#discussion_r122862830
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -248,6 +249,10 @@ private[hive] class HiveMetastoreCatalog(sparkSession:
SparkSession) extends Log
if (inferenceMode == INFER_AND_SAVE) {
updateCatalogSchema(relation.tableMeta.identifier, schema)
}
+
+ SchemaUtils.checkSchemaColumnNameDuplication(
--- End diff --
I checked code again and it seems I found no column duplication happen here
if the hive catalog has no name duplication. `mergeWithMetastoreSchema` merges
a catalog schema with an inferred one on the catalog names, so IIUC this does
not lead to the duplication. So, we could safely remove this check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
