Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18356#discussion_r123156355
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -181,6 +197,12 @@ case class DataSource(
throw new AnalysisException(
s"Unable to infer schema for $format. It must be specified
manually.")
}
+
+ checkColumnNameDuplication(
+ (dataSchema ++ partitionSchema).map(_.name),
+ "in the datasource",
+ sparkSession.sessionState.conf.caseSensitiveAnalysis)
--- End diff --
Since the new RC of 2.2 is out, how about submitting the PR to the master
branch using your `SchemaUtils.scala` with the corresponding test cases,
instead of creating a new function `checkColumnNameDuplication`?
This can simplify the future back-port merging to 2.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
