Github user WangTaoTheTonic commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18123634
--- Diff: sbin/spark-daemon.sh ---
@@ -142,8 +142,12 @@ case $startStop in
spark_rotate_log "$log"
echo starting $command, logging to $log
- cd "$SPARK_PREFIX"
- nohup nice -n $SPARK_NICENESS "$SPARK_PREFIX"/bin/spark-class $command
"$@" >> "$log" 2>&1 < /dev/null &
+ if [ $option == spark-submit ]; then
+ nohup nice -n $SPARK_NICENESS "$SPARK_PREFIX"/bin/spark-submit
--class $command \
--- End diff --
Yeah you are right, but if we put `gatherSparkSubmitOpts` before
`spark-submit` there comes a trouble that as `gatherSparkSubmitOpts` takes an
argument `SUBMIT_USAGE_FUNCTION` which is different in those scripts who invoke
`gatherSparkSubmitOpts`(now we have three: `start-thriftserver.sh`, `spark-sql`
and `pyspark`).
Instead of passing different `SUBMIT_USAGE_FUNCTION` and sourcing
`bin/utils.sh` inside of `spark-daemon.sh`, maybe it's better to assign values
to `SUBMISSION_OPTS` and `APPLICATION_OPTS` outside of it.
There exists another option that we would not passing
`SUBMIT_USAGE_FUNCTION` to `gatherSparkSubmitOpts` which leads to less
user-friendliness.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
