Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17074#discussion_r123254715
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -38,13 +38,15 @@ import org.apache.spark.util.{ParentClassLoader, Utils}
* Allows the user to specify if user class path should be first.
* This class loader delegates getting/finding resources to parent loader,
* which makes sense until REPL never provide resource dynamically.
+ * This class does not set parent classloader since this class loader
--- End diff --
How about rephrase to:
```
[[ClassLoader]] will preferentially load class from parent. Only when
parent is null or the load failed, that it will call the overridden `findClass`
function. To avoid the potential issue caused by loading class using
inappropriate class loader, we should set the parent of ClassLoader to null, so
that we can fully control which class loader is used.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
