Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18371#discussion_r123404096
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -34,6 +34,30 @@ NULL
     #' df <- createDataFrame(cbind(model = rownames(mtcars), mtcars))}
     NULL
     
    +#' Math functions for Column operations
    +#'
    +#' Math functions defined for \code{Column}.
    +#'
    +#' @param x Column to compute on. In \code{shiftLeft}, \code{shiftRight} 
and \code{shiftRightUnsigned},
    +#'          this is the number of bits to shift.
    +#' @param y Column to compute on.
    +#' @param ... additional argument(s).
    +#' @name column_math_functions
    +#' @rdname column_math_functions
    +#' @family math functions
    +#' @examples
    +#' \dontrun{
    +#' # Dataframe used throughout this doc
    +#' df <- createDataFrame(cbind(model = rownames(mtcars), mtcars))
    +#' tmp <- mutate(df, v1 = log(df$mpg), v2 = cbrt(df$disp),
    +#'                   v3 = bround(df$wt, 1), v4 = bin(df$cyl),
    +#'                   v5 = hex(df$wt), v6 = toDegrees(df$gear),
    +#'                   v7 = atan2(df$cyl, df$am), v8 = hypot(df$cyl, df$am),
    +#'                   v9 = pmod(df$hp, df$cyl), v10 = shiftLeft(df$disp, 1),
    +#'                   v11 = conv(df$hp, 10, 16))
    --- End diff --
    
    agreed we don't need to have example for each of atan/tan/cos/sin/sinh etc..
    
    how about adding back one of each of these though
    ```
    sign(df$c)
    signum(df$c)
    
    ceil(df$c)
    ceiling(df$c)
    
    sqrt(df$c)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to