Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18387#discussion_r123571267
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -817,6 +818,18 @@ case class Sample(
child: LogicalPlan)(
val isTableSample: java.lang.Boolean = false) extends UnaryNode {
+ val eps = RandomSampler.roundingEpsilon
--- End diff --
I think the bounds can be generated programmatically in users' code. Any
number within [0-eps, 1+eps] can be handled by RandomSampler. Also,
AstBuilder.scala use eps for fraction validation as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
