Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/18364#discussion_r123587631
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2562,37 +2563,63 @@ object TimeWindowing extends Rule[LogicalPlan] {
case a: Attribute => a.metadata
case _ => Metadata.empty
}
- val windowAttr =
- AttributeReference("window", window.dataType, metadata =
metadata)()
- val maxNumOverlapping = math.ceil(window.windowDuration * 1.0 /
window.slideDuration).toInt
- val windows = Seq.tabulate(maxNumOverlapping + 1) { i =>
- val windowId = Ceil((PreciseTimestamp(window.timeColumn) -
window.startTime) /
- window.slideDuration)
+ def getWindow(i: Int, maxNumOverlapping: Int): Expression = {
--- End diff --
I'm not sure I understand `maxNumOverlapping` as a name that we tabulate
over. Isn't it like the `overlapNumber` or something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
