Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18327#discussion_r123681974
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -739,6 +739,157 @@ class ColumnarBatchSuite extends SparkFunSuite {
}}
}
+ test("Nest Array(not containing null) in Array.") {
+ (MemoryMode.ON_HEAP :: MemoryMode.OFF_HEAP :: Nil).foreach { memMode =>
+ val column = ColumnVector.allocate(10, new ArrayType(new
ArrayType(IntegerType, false), true),
+ memMode)
+ val childColumn = column.arrayData()
+ val data = column.arrayData().arrayData()
+ (0 until 6).foreach { i =>
+ data.putInt(i, i)
+ }
+ // Arrays in child column: [0], [1, 2], [], [3, 4, 5]
+ childColumn.putArray(0, 0, 1)
+ childColumn.putArray(1, 1, 2)
+ childColumn.putArray(2, 2, 0)
+ childColumn.putArray(3, 3, 3)
+ // Arrays in column: [[0]], [[1, 2], []], [[], [3, 4, 5]], null
+ column.putArray(0, 0, 1)
+ column.putArray(1, 1, 2)
+ column.putArray(2, 2, 2)
+ column.putNull(3)
+
+ assert(column.getArray(0).getArray(0).toIntArray() === Array(0))
+ assert(column.getArray(1).getArray(0).toIntArray() === Array(1, 2))
+ assert(column.getArray(1).getArray(1).toIntArray() === Array())
+ assert(column.getArray(2).getArray(0).toIntArray() === Array())
+ assert(column.getArray(2).getArray(1).toIntArray() === Array(3, 4,
5))
+ assert(column.isNullAt(3))
+ }
+ }
+
+ test("Nest Array(containing null) in Array.") {
--- End diff --
Ah, you are right since now we are testing correct cases.
Is it better to add a test suite to put `null` into an array for the case
`ColumnVector.allocate(10, new ArrayType(new ArrayType(IntegerType, false),
true))`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
