Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18366#discussion_r123690523 --- Diff: R/pkg/R/functions.R --- @@ -86,6 +86,22 @@ NULL #' df <- createDataFrame(data.frame(time = as.POSIXct(dts), y = y))} NULL +#' String functions for Column operations +#' +#' String functions defined for \code{Column}. +#' +#' @param x Column to compute on. In \code{instr}, it is the substring to check. In \code{format_number}, --- End diff -- `instr` seems to be the odd one here. it's `instr(y, x)` - should there be doc on `y` first/too?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org